search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
156 stars 146 forks source link

No pr review notifications if my team was assigned as reviewer #704

Open nielmistry opened 9 months ago

nielmistry commented 9 months ago

Linked this plugin to mattermost, I get PR review notifications if my account specifically is selected as reviewer. My account is also part of the "software" team on Github, but when the whole software team is assigned I do not get notified

Looked through the source code and doesn't look like it handles the case where the team was assigned: https://github.com/mattermost/mattermost-plugin-github/blob/52beef2209d6aa575e49091ec561cfaaa7d65fc5/server/plugin/webhook.go#L1176-L1184

I think this also applies to issues as well

raghavaggarwal2308 commented 2 months ago

@nielmistry @mickmister I tried to reproduce the issue on our end but it seems to be working fine when we are assigning a team as a reviewer on a PR. Each member of the team is getting notified about the review request except in the following cases:

  1. If any person from the team is the creator of the PR then only the creator of the PR will not get notified. (All other members will get notified)
  2. If the person requesting the review is a part of the team then he will not be notified. (All other members will get notified)

Can you please confirm you are not facing the issue because of the above two points?

nielmistry commented 2 months ago

Hey @raghavaggarwal2308 thanks for the reply.

There have been quite a few PR requests made to a team that I'm a part of and I've not received any notifications.

I wasn't the person who authored most of those PRs.

raghavaggarwal2308 commented 2 months ago

@nielmistry Are you the only one facing the issue or the other team members are also not getting notified?

Also can you provide me the following details so that we can try to debug the issue further:

  1. Which MM server version you are using?
  2. Is the Github repo public or Private?
  3. Server log at the moment when the PR is assigned to a team for review.
raghavaggarwal2308 commented 1 week ago

@nielmistry Are you still facing the issue or we can close it?