search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 148 forks source link

Bump version to 2.2.0. #709

Closed avas27JTG closed 6 months ago

avas27JTG commented 10 months ago

Summary

avas27JTG commented 10 months ago

Can we get the open PRs that only require QA review into this release?

Sure, let me look

avas27JTG commented 10 months ago

Can we get the open PRs that only require QA review into this release?

Sure, let me look

@hanzei I added them to this release milestone, and the QA will start testing these issues, after which we can merge them into the master.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7da125a) 15.85% compared to head (ff05dfc) 15.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #709 +/- ## ======================================= Coverage 15.85% 15.85% ======================================= Files 15 15 Lines 5778 5778 ======================================= Hits 916 916 Misses 4820 4820 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avas27JTG commented 9 months ago

Can we get the open PRs that only require QA review into this release?

Sure, let me look

@hanzei I added them to this release milestone, and the QA will start testing these issues, after which we can merge them into the master.

@hanzei can you please approve the PR if it looks good to you?

avas27JTG commented 9 months ago

@mickmister min_server_version is changed to 7.1.0 in this PR https://github.com/mattermost/mattermost-plugin-github/pull/598 so, should we still keep this release as v2.2.0 or change it to v3.0.0?.

mickmister commented 9 months ago

@avas27JTG I'm genuinely not sure if bumping the min server version constitutes a new major version of the plugin. We haven't done that in the past.

I'm thinking no, because the main reason we do major version changes is so that the admin is aware of breaking changes. In this case, the only side effect is they just won't be able to upgrade if they are on an older server version. There's not really a breaking change in that regard.

avas27JTG commented 9 months ago

@avas27JTG I'm genuinely not sure if bumping the min server version constitutes a new major version of the plugin. We haven't done that in the past.

I'm thinking no, because the main reason we do major version changes is so that the admin is aware of breaking changes. In this case, the only side effect is they just won't be able to upgrade if they are on an older server version. There's not really a breaking change in that regard.

Makes sense, thanks @mickmister we will keep it as a minor release.

avas27JTG commented 9 months ago

I would like (1/5) to get #712 into the release, but I'm fine with releasing the code as it is.

Yes, we have planned to include it here, this is in QA review currently.

mickmister commented 9 months ago

I think we should also try to get https://github.com/mattermost/mattermost-plugin-github/pull/718 into the release. Very small impactful PR

avas27JTG commented 9 months ago

@mickmister @hanzei #712 and #718 are now included.

hanzei commented 9 months ago

@avas27JTG @AayushChaudhary0001 Are we good to merge the PR and cut the release?

mickmister commented 9 months ago

@hanzei I created an RC build and requested to be installed on community https://community.mattermost.com/core/pl/zd4h5ifbtjngbmi8d87we3x5wa

avas27JTG commented 9 months ago

@avas27JTG @AayushChaudhary0001 Are we good to merge the PR and cut the release?

Yes @hanzei we have created a playbook for it as per our release process and RC is also created by @mickmister

mickmister commented 7 months ago

@avas27JTG @raghavaggarwal2308 Are there any recent changes to the master branch that we don't want to include in this release? Wondering if we can get this in there https://github.com/mattermost/mattermost-plugin-github/pull/729. Let me know, and I'll cut another RC with the latest changes

raghavaggarwal2308 commented 7 months ago

Are there any recent changes to the master branch that we don't want to include in this release?

@mickmister No I think we can cut the RC with latest changes. We have just merged the changes for description issue and see more link in the tooltip after our last RC (https://github.com/mattermost/mattermost-plugin-github/pull/735).

mickmister commented 7 months ago

@raghavaggarwal2308 Can you please merge the latest into this branch to get https://github.com/mattermost/mattermost-plugin-github/pull/729 into the release?

raghavaggarwal2308 commented 6 months ago

@mickmister The branch and PR description is updated now cc: @avas27JTG

hanzei commented 6 months ago

@mickmister Are we good to cut the release? Is there anything blocking it?

mickmister commented 6 months ago

@hanzei Yes I think we're good to go. We've had 36e72f4 running on community for a bit now, and only a few changes/fixes have been added since then.