search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 148 forks source link

[GH-593] Add feature flag for new pull requests #712

Closed San4es closed 9 months ago

San4es commented 9 months ago

This is recreation of @C-Deck's PR #612 with additional changes addressing these code review comments: https://github.com/mattermost/mattermost-plugin-github/pull/612#issuecomment-1441283421

Closes https://github.com/mattermost/mattermost-plugin-github/issues/593.

mattermost-build commented 9 months ago

Hello @San4es,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

San4es commented 9 months ago

/check-cla

codecov-commenter commented 9 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (8cf783f) 15.49% compared to head (9fa9a04) 15.76%.

:exclamation: Current head 9fa9a04 differs from pull request most recent head 12a2aa5. Consider uploading reports for the commit 12a2aa5 to get more accurate results

Files Patch % Lines
server/plugin/command.go 55.00% 9 Missing :warning:
server/plugin/webhook.go 0.00% 3 Missing :warning:
server/plugin/subscriptions.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #712 +/- ## ========================================== + Coverage 15.49% 15.76% +0.26% ========================================== Files 15 15 Lines 5737 5755 +18 ========================================== + Hits 889 907 +18 Misses 4806 4806 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanzei commented 9 months ago

@AayushChaudhary0001 The PR is ready for your review