mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 148 forks source link

[GH-717] Implement subscription notification for pull request "reopened" event #718

Closed raghavaggarwal2308 closed 9 months ago

raghavaggarwal2308 commented 9 months ago

Summary

Screenshot:

image

What to test?

Steps to reproduce:
  1. Connect your GitHub account.
  2. Create a subscription of event type "pulls" in a channel.
  3. Reopen a closed PR on GitHub for the project you have created a subscription for.
Expected behavior:
Environment:

MM version: v9.2.2 Node version: 14.18.0 Go version: 1.20.11

Ticket Link

Fixes #717

codecov-commenter commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (8cf783f) 15.49% compared to head (881d2be) 15.79%. Report is 1 commits behind head on master.

Files Patch % Lines
server/plugin/webhook.go 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #718 +/- ## ========================================== + Coverage 15.49% 15.79% +0.30% ========================================== Files 15 15 Lines 5737 5767 +30 ========================================== + Hits 889 911 +22 - Misses 4806 4814 +8 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raghavaggarwal2308 commented 9 months ago

@mickmister FIxed the review comments mentioned by you