mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

[MM-17] Fix mention notifications and label/milestone RHS display #721

Closed raghavaggarwal2308 closed 9 months ago

raghavaggarwal2308 commented 10 months ago

Summary

  1. Mention notifications not working.
  2. Labels and milestones not displayed in the RHS.

What to test?

Steps to reproduce:

Ticket Link

N/A

codecov-commenter commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5aa2450) 15.79% compared to head (ea87542) 15.78%.

Files Patch % Lines
server/plugin/plugin.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #721 +/- ## ========================================== - Coverage 15.79% 15.78% -0.01% ========================================== Files 15 15 Lines 5767 5770 +3 ========================================== Hits 911 911 - Misses 4814 4817 +3 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raghavaggarwal2308 commented 9 months ago

@hanzei Gentle reminder for re-review

raghavaggarwal2308 commented 9 months ago

@mickmister Fixed the comments added by you