search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

[MM-36] Update plugin with respect to phase 1 upgrades #727

Closed ayusht2810 closed 8 months ago

ayusht2810 commented 10 months ago

Summary

Updated plugin with respect to phase 1 upgrades

Ticket Link

hanzei commented 10 months ago

@ayusht2810 Can you please merge master into your PR?

ayusht2810 commented 10 months ago

@hanzei I have kept use-branch as my base branch because this PR covers the rest of the plugin upgrades required for Phase 1. The other changes are present in the PR. Let me know your thoughts on it.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (44f9c83) 15.85% compared to head (96081af) 15.93%.

Files Patch % Lines
build/pluginctl/logs.go 37.39% 72 Missing :warning:
server/plugin/command.go 0.00% 5 Missing :warning:
build/pluginctl/main.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #727 +/- ## ========================================== + Coverage 15.85% 15.93% +0.08% ========================================== Files 15 17 +2 Lines 5778 6018 +240 ========================================== + Hits 916 959 +43 - Misses 4820 5017 +197 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 10 months ago

/update-branch

hanzei commented 9 months ago

Let's merge https://github.com/mattermost/mattermost-plugin-github/pull/725 first.