search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). #728

Closed arush-vashishtha closed 9 months ago

arush-vashishtha commented 10 months ago

Summary

The feature implemented in the PR https://github.com/mattermost/mattermost-plugin-github/pull/683 should also contain the feature to show the list of excluded repositories in the list of subscriptions.

Steps to reproduce

  1. Enter the slash command /github subscriptions add <organization> --exclude <repo> <feature> in the desired channel and create subscription for the organization with some repositories excluded.
  2. Navigate to the desired channel or DM/GM on MM and enter the slash command /github subscriptions list.

Expected behavior

The created subscription should show the details of the excluded repositories along with the events in the list of subscriptions.

Actual behavior

Showing only the subscriptions in the desired channel or DM/GM on MM.

ScreenShots

image

hanzei commented 9 months ago

Good catch @arush-vashishtha :+1:

raghavaggarwal2308 commented 9 months ago

@hanzei @mickmister This issue is not reproducible anymore. I have verified the same with @arush-vashishtha as well. Maybe it was a glitch earlier. Can we close this? image