[GH-733] Updated the "issue_creations" subscription to post notification when an issue is labeled/reopened

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost

Apache License 2.0

157 stars 148 forks source link

[GH-733] Updated the "issue_creations" subscription to post notification when an issue is labeled/reopened #736

Closed raghavaggarwal2308 closed 6 months ago

raghavaggarwal2308 commented 7 months ago

Summary

Updated the "issue_creations" subscription to post a notification when an issue is labeled/reopened

Screenshots

What to test:

Notification is getting posted when an existing issue is labeled in a channel with a subscription for issue_creations,label:"label-name"
Notification is posted when an issue is reopened in a channel with a subscription for issue_creations

Steps to test:

Connect your GitHub account
Create a subscription for issue_creations,label:"label-name" is a channel.
Add a label (same as present in the subscription) to an existing issue.

Ticket Link

Fixes #733

mickmister commented 7 months ago

Wondering if you would be up for also changing the string of the "person opened an issue", to include the string "with label x" when it has a label that matches a subscription in the channel

I think that "with label x" may need to be applied in multiple other places as well

codecov-commenter commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2608197) 15.78% compared to head (7a5fc82) 15.78%.

Files	Patch %	Lines
server/plugin/command.go	50.00%	1 Missing :warning:
server/plugin/webhook.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #736 +/- ## ======================================= Coverage 15.78% 15.78% ======================================= Files 15 15 Lines 5770 5770 ======================================= Hits 911 911 Misses 4817 4817 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raghavaggarwal2308 commented 7 months ago

Wondering if you would be up for also changing the string of the "person opened an issue", to include the string "with label x" when it has a label that matches a subscription in the channel

@mickmister Sure, I will make the change

mickmister commented 7 months ago

@raghavaggarwal2308 We can do the above change in a separate PR. Created an issue for this here https://github.com/mattermost/mattermost-plugin-github/issues/742