Closed ayusht2810 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 16.16%. Comparing base (
6cc3429
) to head (7b58b12
). Report is 5 commits behind head on master.:exclamation: Current head 7b58b12 differs from pull request most recent head b9e4833. Consider uploading reports for the commit b9e4833 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mickmister Gentle reminder to re-review the PR.
@mickmister fixed the review comments. Please re-review.
@AayushChaudhary0001 Gentle reminder to QA to review the changes.
@hanzei Will test it by end of this week, if this is not of high priority. Please let me know if this needs to be tested urgently.
End of week is fine, thanks @AayushChaudhary0001
@mickmister Should we merge the above PR and start creating HW (typescript migration) tickets?
@ayusht2810 Yeah merged :+1:
@ayusht2810 Before creating the tickets, I think we should have one example PR that shows how to convert a given component (and index.ts
file in the case of this project), to show how a given typescript migration can be done, and also to validate the current state that it is ready for components to be migrated
Summary
Ticket Link
NA
What to test?