mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 150 forks source link

[MM-199] Convert files related to redux from js to ts #743

Closed ayusht2810 closed 5 months ago

ayusht2810 commented 8 months ago

Summary

Ticket Link

NA

What to test?

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.16%. Comparing base (6cc3429) to head (7b58b12). Report is 5 commits behind head on master.

:exclamation: Current head 7b58b12 differs from pull request most recent head b9e4833. Consider uploading reports for the commit b9e4833 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #743 +/- ## ======================================= Coverage 16.16% 16.16% ======================================= Files 17 17 Lines 6021 6021 ======================================= Hits 973 973 Misses 5003 5003 Partials 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ayusht2810 commented 6 months ago

@mickmister Gentle reminder to re-review the PR.

ayusht2810 commented 5 months ago

@mickmister fixed the review comments. Please re-review.

hanzei commented 5 months ago

@AayushChaudhary0001 Gentle reminder to QA to review the changes.

AayushChaudhary0001 commented 5 months ago

@hanzei Will test it by end of this week, if this is not of high priority. Please let me know if this needs to be tested urgently.

hanzei commented 5 months ago

End of week is fine, thanks @AayushChaudhary0001

ayusht2810 commented 5 months ago

@mickmister Should we merge the above PR and start creating HW (typescript migration) tickets?

mickmister commented 5 months ago

@ayusht2810 Yeah merged :+1:

mickmister commented 5 months ago

@ayusht2810 Before creating the tickets, I think we should have one example PR that shows how to convert a given component (and index.ts file in the case of this project), to show how a given typescript migration can be done, and also to validate the current state that it is ready for components to be migrated