search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
157 stars 148 forks source link

Bump go version for playwright test #751

Closed hanzei closed 6 months ago

hanzei commented 6 months ago

Summary

The playwright test are currenly failing on master with go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.19. (https://github.com/mattermost/mattermost-plugin-github/actions/runs/8134028209/job/22226371191) Let's bump the go version there and see if that fixes things.

Ticket Link

NONE

hanzei commented 6 months ago

It's failing with a different error :tada:

https://github.com/mattermost/mattermost-plugin-github/actions/runs/8218101374

@mickmister Maybe we disable the job until it has been fixed?

mickmister commented 5 months ago

@mickmister Maybe we disable the job until it has been fixed?

Yes sounds good :+1: Does simply removing the workflow file seem the right way?

hanzei commented 5 months ago

I disabled the workflow manually via https://github.com/mattermost/mattermost-plugin-github/actions/workflows/playwright.yml.