search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
156 stars 146 forks source link

Fix flaky TestFilterLogEntries #753

Closed hanzei closed 4 months ago

hanzei commented 4 months ago

Summary

Downstream https://github.com/mattermost/mattermost-plugin-starter-template/pull/197

Ticket Link

https://github.com/mattermost/mattermost-plugin-github/pull/745#issuecomment-1980252985

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.16%. Comparing base (0100b54) to head (8fcd74c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #753 +/- ## ======================================= Coverage 16.16% 16.16% ======================================= Files 17 17 Lines 6021 6021 ======================================= Hits 973 973 Misses 5003 5003 Partials 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 4 months ago

@ayusht2810 @raghavaggarwal2308 FYI this may need to be applied to other plugin repos as well. @hanzei What's the drawback to not updating this on a plugin repo? Do the unit tests fail?

hanzei commented 4 months ago

Do the unit tests fail?

The tests are flaky and fail from time to time.