search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
156 stars 146 forks source link

Fixes #497: "Validation Message spacing (UI) issue" #763

Open cyrusjc opened 3 months ago

cyrusjc commented 3 months ago

Fixes https://github.com/mattermost/mattermost-plugin-github/issues/497

image

Used inline style to avoid other possible changes to either 'error-text' or 'help-text'

Spaces now match the spacing between "Returns Github repositories....", "This field is required", and the fields themselves.

Edit: Accidentally linked wrong issue (498)

mattermost-build commented 3 months ago

Hello @cyrusjc,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

ayusht2810 commented 3 months ago

@cyrusjc The spacing still looks a bit off for the field Description for the GitHub Issue and its error field as compared to the field Repository. Can you please make the spacing consistent for that as well?  Also, there is a typo in the second error text, requised. Can you please fix that as well, if possible?

cyrusjc commented 3 months ago

Yea for sure, I'll change the spacing there as well.

As for requised that was a small typo I made while I was working on this issue. I took the screenshot before I fixed the typo and the typo wasn't commited.

cyrusjc commented 3 months ago

After proposed changes

image

mattermost-build commented 3 months ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 3 months ago

@Kshitij-Katiyar Can you please take a look?

mickmister commented 2 months ago

@matthewbirtch This is a custom modal implemented by the plugin. Do you have thoughts on how the spacing should be between the different form elements and error messages?

matthewbirtch commented 2 months ago

@abhijit-singh can I ask your help to provide a recommendation for spacing here?

abhijit-singh commented 2 months ago

@mickmister Here's the proposed spacing between the different form elements in the modal -

image
cyrusjc commented 2 months ago

as per mockup

image

AayushChaudhary0001 commented 2 months ago

The above PR was tested and looks like the statement 1, of the issue #497 is still not fixed in this PR.

The spacing between the error messages with respect to the input field are different. The spacing between error message and input field consists and extra spacing of 8 pixels. Please refer to the screenshot below

image

cc: @cyrusjc

cyrusjc commented 2 months ago

The above PR was tested and looks like the statement 1, of the issue #497 is still not fixed in this PR.

The spacing between the error messages with respect to the input field are different. The spacing between error message and input field consists and extra spacing of 8 pixels. Please refer to the screenshot below

image

cc: @cyrusjc

Apologies, should be fixed now:

8px around top error text: image

8px around bottom error text: image

mattermost-build commented 1 month ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!