[MM-405]: Fixed the pull review request events not working

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost

Apache License 2.0

157 stars 150 forks source link

[MM-405]: Fixed the pull review request events not working #768

Closed Kshitij-Katiyar closed 3 months ago

Kshitij-Katiyar commented 5 months ago

Summary

Fixed the issue that the pull request review event not working. Removed the GetComment.GetDiffHunk from the template as it can be very long and not that very useful. Also changed the name for the type of the post.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-github/issues/405

Kshitij-Katiyar commented 3 months ago

@Kshitij-Katiyar There's a PR that was submitted that solves this same issue #778. Can you please take a look there and compare any changes that may need to be added here?

Thanks for the PR, added some useful changes from the PR

Kshitij-Katiyar commented 3 months ago

@mickmister Fixed the comments, please look into it.

Kshitij-Katiyar commented 3 months ago

@mickmister Fixed the comments, please have a look