Update subscription messages with respect to webhook

[ayusht2810]

Summary

• Update subscription message when user is not authorized to access webhooks
• Update subscription message when there is no webhook present

Screenshots

• When user is not authorized to access webhooks

  Before

  

  After

  

• When there is no webhook present

  Before

  

  After

  

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-github/issues/715 Fixes https://github.com/mattermost/mattermost-plugin-github/issues/732

What to test?

• Create a subscription with the user who doesn't have access to create webhooks and verify the post
• Similarly, create a subscription with no prior webhook present and verify the post

[ayusht2810]

@hanzei added the comment for the above changes in the code. Please re-review

[mickmister]

It looks like the screenshots changed the behavior of public vs ephemeral messages. Is this the case?

[ayusht2810]

@mickmister Are you talking about the first case where the user doesn't have access to webhooks? If yes, the screenshot was missing the part for the public message. I have added a screenshot for both the cases again: Case 1: Case 2:

[mickmister]

@ayusht2810 The duplicated text between the public and ephemeral messages is a bit confusing. If there is an ephemeral message involved with the response, I think we should remove any duplicated text that also exists in the public post. If the entire message is duplicated, then we can just omit the ephemeral message in that case. What do you think?

[ayusht2810]

@mickmister Updated the messages: Let me know if anything else needs to be changed here.