[MM-420] Add feature to support multiple orgs in plugin settings

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost

Apache License 2.0

156 stars 146 forks source link

[MM-420] Add feature to support multiple orgs in plugin settings #773

Open ayusht2810 opened 3 months ago

ayusht2810 commented 3 months ago

Summary

Added feature to support multiple orgs in plugin settings
Updated Readme

Ticket Link

Fixes #552

What to test?

Add comma separated organizations name in plugin settings.
Test all the features required with the above change and check if we get all the details related to different organization

Checklist

[x] Completed dev testing
[x] make test Ran test cases and ensured they are passing
[x] make check-style Ran style check and ensured both webapp and server pass the checks

ayusht2810 commented 2 months ago

@hanzei fixed the review comments. Please re-review.

ayusht2810 commented 2 months ago

@hanzei Fixed the review comments. Please re-review

mickmister commented 2 months ago

@AayushChaudhary0001 Did you also test the case of not having an org configured?

AayushChaudhary0001 commented 2 months ago

@mickmister Yes, I have tested it with empty field as well for the org support, works fine even if no org is added.

mickmister commented 2 months ago

@AayushChaudhary0001 Got it, thank you :+1:

mickmister commented 2 months ago

@ayusht2810 There are some conflicts to resolve here

mickmister commented 1 month ago

@Kshitij-Katiyar @raghavaggarwal2308 I'm curious where this is at currently? On the community server we're currently unable to efficiently collaborate on the mattermost-community projects. Not super urgent, but I don't want this to fall through here. Just checking in

Kshitij-Katiyar commented 1 month ago

@mickmister Fixed the conflicts and updated the code with the suggestions. Please have a look.

Kshitij-Katiyar commented 1 month ago

@mickmister Fixed the suggestions, please have a look.

AayushChaudhary0001 commented 3 weeks ago

@ayusht2810 I found a issue while testing this PR: Issue: Data is not getting updated for multiple orgs in LHS

Steps to reproduce:

Connect a github account to Mattermost
Go to plugin settings of Github on Mattermost
Add multiple orgs
Check the data in LHS

Actual - Multiple orgs data is not getting updated in LHS Expected - Multiple orgs data should get updated in LHS

raghavaggarwal2308 commented 2 weeks ago

@AayushChaudhary0001 The above issue is fixed now. Please re-test.