search

mattermost / mattermost-plugin-github

GitHub plugin for Mattermost
Apache License 2.0
156 stars 146 forks source link

[GH-647]: Hide UsePreregisteredApplication on on-prem instances #774

Closed Kshitij-Katiyar closed 2 months ago

Kshitij-Katiyar commented 2 months ago

Summary

Using the hoisting property the UsePreregisteredApplication will only be on cloud servers.

Ticket Link

https://github.com/mattermost/mattermost-plugin-github/issues/647

Testing Steps

The UsePreregisteredApplication will be hidden in on-prem servers and can only be seen in cloud instances.

Kshitij-Katiyar commented 2 months ago

Should we update min_server_version to ensure newer server pick up the setting correctly?

I have tested this on mattermost cloud server v9.4.0 and it was working fine for that. @hanzei