search

mattermost / mattermost-plugin-google-calendar

Mattermost Google Calendar Plugin
35 stars 35 forks source link

First try to fix linter errors #17

Closed AugustasV closed 4 years ago

AugustasV commented 4 years ago

Summary

Uploaded Golang lint build step to the project and tried to fix some of linter errors. Would like to hear suggestions.

Ticket Link

First try https://github.com/mattermost/mattermost-plugin-google-calendar/issues/13

mattermod commented 4 years ago

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

hanzei commented 4 years ago

/update-branch

mattermod commented 4 years ago

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

hanzei commented 4 years ago

/update-branch

mattermod commented 4 years ago

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

AugustasV commented 4 years ago

@hanzei thanks for comments, any direction how I should fix remaining linter warnings?

hanzei commented 4 years ago

@AugustasV You can comment out the goconst linter as it's not high value and hard to fix sometimes. You can also disable errcheck as it take a lot of time to fixe those.

The rest should be easy to fix. gosimple and golint make up for the most of the remaining issues. Let me know if you need any additional help.

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

AugustasV commented 4 years ago

@hanzei disabled linters which was hard to fix. Now linter is passing.

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers

mattermod commented 4 years ago

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream. /cc @mattermost/core-security @mattermost/core-build-engineers