mattermost / mattermost-plugin-google-calendar

Mattermost Google Calendar Plugin
35 stars 35 forks source link

golang-cli-lint error fixed during automake operation: server/plugin.… #35

Closed DmitriyKalekin closed 2 years ago

DmitriyKalekin commented 2 years ago

…go:15:13: fieldalignment: struct with 72 pointer bytes could be 48 (govet)

This error arises in golangci-lint during run make.

The reason of this bug - bad maligned struct. I used this article [https://medium.com/@sebassegros/golang-dealing-with-maligned-structs-9b77bacf4b97] to make compact alignment in type Plugin struct

After this change my plugin was built correctly.

mattermod commented 2 years ago

Hello @DmitriyKalekin,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

DmitriyKalekin commented 2 years ago

/check-cla

DmitriyKalekin commented 2 years ago

/check-cla

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

danielzzz commented 2 years ago

hello! is there any chance this would be merged soon? thanks a lot!

hanzei commented 2 years ago

https://github.com/mattermost/mattermost-plugin-google-calendar/pull/35#pullrequestreview-922960607 is blocking the merge

hanzei commented 2 years ago

Closing in favor of https://github.com/mattermost/mattermost-plugin-google-calendar/pull/40