search

mattermost / mattermost-plugin-google-calendar

Mattermost Google Calendar Plugin
38 stars 35 forks source link

v1.0.0 Google Calendar Plugin #41

Closed fmartingr closed 1 year ago

fmartingr commented 1 year ago

Summary

This pull request introduces the v1.0.0 Google Calendar release created in the https://github.com/mattermost/mattermost-plugin-mscalendar repository as groundwork for sharing common code for similar plugins.

This PR leverages the work done in that plugin to allow some of the features and allow compatibility with HA environments, check the README.md for more details on features.

fmartingr commented 1 year ago

50k lines of code is a bit too much to review in one PR. What are the files that I specifically should take a look at?

Code is mostly the same we had in the mscalendar plugin, so the main server, and that general things for the plugin are in place and I haven't forgot to migrate anything.

Not asking for an in-depth review of course, just that what I migrated makes sense, logic was reviewed some time ago.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@ac997a6). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #41 +/- ## ========================================= Coverage ? 11.22% ========================================= Files ? 16 Lines ? 606 Branches ? 0 ========================================= Hits ? 68 Misses ? 536 Partials ? 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 1 year ago

Reusing the same repo as the archived one seems weird, but I saw the discussion on it and I suppose that's the plan we're going with. What was your method of getting the code onto this repo?

fmartingr commented 1 year ago

Reusing the same repo as the archived one seems weird, but I saw the discussion on it and I suppose that's the plan we're going with. What was your method of getting the code onto this repo?

I'd rather go with this without breaking release semver (which we are not) than having a lot of repositores for the same thing. And we are going to have the history anyway.

Essentially, I removed all the files and replaced them with the ones from the Google Calendar plugin PoC that I did the other day.

fmartingr commented 1 year ago

Adding the Docs/Needed label since the repository URL has changed, and to get some eyes on the README.md.