mattermost / mattermost-plugin-jira

JIRA plugin for Mattermost 🔌
https://mattermost.gitbook.io/plugin-jira/
Apache License 2.0
97 stars 127 forks source link

Migrate from dgrijalva/jwt-go to golang-jwt #1063

Closed hanzei closed 2 months ago

hanzei commented 3 months ago

Summary

Ticket Link

https://github.com/mattermost/mattermost-plugin-jira/security/dependabot/2

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.37%. Comparing base (b9a0a22) to head (db7f9d9). Report is 1 commits behind head on master.

:exclamation: Current head db7f9d9 differs from pull request most recent head 5c079de. Consider uploading reports for the commit 5c079de to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1063 +/- ## ======================================= Coverage 33.37% 33.37% ======================================= Files 53 53 Lines 8008 8008 ======================================= Hits 2673 2673 Misses 5112 5112 Partials 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanzei commented 2 months ago

@AayushChaudhary0001 Can you please do some smoke testing around the JWT connection process?

hanzei commented 2 months ago

@AayushChaudhary0001 Can you confirm that the reported issue is only reproducible on this branch and not on master?

AayushChaudhary0001 commented 2 months ago

@hanzei I have tested that this issue also exists on master branch and is reproducible there as well.

hanzei commented 2 months ago

Would you please file a separate ticket for that please, @AayushChaudhary0001?

hanzei commented 2 months ago

@AayushChaudhary0001 Are we good to merge this PR?

hanzei commented 2 months ago

Gentle ping @AayushChaudhary0001 :smile: