Subtasks are not supported in subscription modal

mattermost / mattermost-plugin-jira

JIRA plugin for Mattermost 🔌

https://mattermost.gitbook.io/plugin-jira/

Apache License 2.0

98 stars 128 forks source link

Subtasks are not supported in subscription modal #993

Closed mickmister closed 3 months ago

mickmister commented 1 year ago

At the moment, we don't support selecting "subtask types" as "issue types" in the subscription modal. It seems this is on purpose based on this line:

https://github.com/mattermost/mattermost-plugin-jira/blob/a86928d1d0c0c2493df5a2690ea8f54f515fd9a5/webapp/src/utils/jira_issue_metadata.tsx#L63

The task here is to look into the feasibility of supporting subtasks in the subscriptions feature. This would also affect the create issue modal if we were to change the line shown above.

Kshitij-Katiyar commented 4 months ago

Hi @mickmister, I explored this further and found that removing the filter from this line will have the following effects:

Subscriptions

Subtasks will be available in the Issue Type dropdown of the Add Jira Subscription modal.
The subscriptions feature works correctly, and notifications are received as expected.

Create Issue

Subtasks will be available in the Issue Type dropdown of the Create Jira Issue modal.
With the current flow, attempting to create an issue with a subtask will result in the following error: Please create your Jira issue manually. The project you tried to create an issue for has required fields this plugin does not yet support: Parent
To allow the creation of a Jira issue for a subtask, we will need to:
1. Add Parent Issue in the createJiraIssue API call payload.
2. Include Parent Issue as an input field in the Create Jira Issue modal.

mickmister commented 4 months ago

@Kshitij-Katiyar Okay so subscriptions are working correctly with subtasks after that small change :+1: Though it leaves the "create issue" modal in a partially broken state with no support for subtasks. How much effort do you think it would take to support subtasks in the "create issue" modal? We already have an issue searching thing per project, so maybe we could just reuse that code/component for searching for the parent issue.

Maybe we can split this up into 2 PRs:

One that makes it so the !i.subtask line only runs for the "create issue" modal. This way subscriptions can immediately support subtasks
One that implements support for the "create issue" modal. I think we can make this one HW

What do you think @Kshitij-Katiyar?

raghavaggarwal2308 commented 4 months ago

@Kshitij-Katiyar Okay so subscriptions are working correctly with subtasks after that small change 👍 Though it leaves the "create issue" modal in a partially broken state with no support for subtasks. How much effort do you think it would take to support subtasks in the "create issue" modal? We already have an issue searching thing per project, so maybe we could just reuse that code/component for searching for the parent issue.

@mickmister I think it will take about 10-12 hrs for adding support for sub-tasks in create issue modal.

Maybe we can split this up into 2 PRs:

One that makes it so the !i.subtask line only runs for the "create issue" modal. This way subscriptions can immediately support subtasks One that implements support for the "create issue" modal. I think we can make this one HW What do you think @Kshitij-Katiyar?

@mickmister That sounds good. We can pick up the second task if there are any requests for that.

Kshitij-Katiyar commented 4 months ago

@mickmister Created an issue for the second task. https://github.com/mattermost/mattermost-plugin-jira/issues/1093