search

mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost
Other
5 stars 6 forks source link

Get CI passing #16

Closed grundleborg closed 4 months ago

fmartingr commented 4 months ago

CI is passing now, do we need to upload this plugin to AWS S3 for distribution? If not we could leverage the community-plugin-cd which only creates a github release.

cc: @wiggin77

wiggin77 commented 4 months ago

CI is passing now, do we need to upload this plugin to AWS S3 for distribution? If not we could leverage the community-plugin-cd which only creates a github release.

cc: @wiggin77

We don't need the AWS upload. Even the github release seems unnecessary on every pr.

fmartingr commented 4 months ago

CI is passing now, do we need to upload this plugin to AWS S3 for distribution? If not we could leverage the community-plugin-cd which only creates a github release. cc: @wiggin77

We don't need the AWS upload. Even the github release seems unnecessary on every pr.

That would be for the CD on tagged releases. CI is already passing (except the delivery with requires AWS).

fmartingr commented 4 months ago

Correct configuration has been added, CI pipeline is now successful on master and CD pipeline should work as well. Please reopen if anything fails.