search

mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost
Other
5 stars 5 forks source link

Minor UX Improvements #33

Closed asaadmahmood closed 7 months ago

asaadmahmood commented 8 months ago

  1. When adding users to a legal hold, I don't think we should use the @ sign, just typing any user should do. image

  2. For the edit, download, release buttons, we should use the icons and make the release button red. Or if that's too much work for now, atleast adding an 8px spacing between them and making the link color for release red should do. image

  3. The starting and ending inputs have different widths on the edit (where they should be the same). image

  4. Should add a border-radius 50px to the chip for the user chip in the users chip.

  5. For the release legal hold, we should show the name of the legal hold you're releasing, otherwise if a user misclicks, he may end up deleting the incorrect legal hold (which may be a big issue. image

Designs here for reference: https://www.figma.com/file/KRW3cvrmrGPfD96Ya2sBVi/Legal-Hold-Plugin?type=design&node-id=1-7&mode=design&t=Cx390rrufTJzNN1I-11

grundleborg commented 8 months ago

@asaadmahmood @jasonblais for point (1), adding users to the list, how do you want it to work? At the moment, it allows searching by any of the usual fields (no need to type @) and then displays them as @username. There are various options (nickname, first+last name, username). What would you like me to use?

grundleborg commented 8 months ago

I've done 3, 4 & 5. @asaadmahmood please could you share SVGs for the icons in (2) and the I can do that one too.

asaadmahmood commented 8 months ago

@grundleborg Do we have access to the compass design icons? If so, the icon is: icon-download-outline and icon-pencil-outline. https://mattermost.github.io/compass-icons/

grundleborg commented 8 months ago

@asaadmahmood @jasonblais for point (1), adding users to the list, how do you want it to work? At the moment, it allows searching by any of the usual fields (no need to type @) and then displays them as @username. There are various options (nickname, first+last name, username). What would you like me to use?

DIscussed with @wiggin77 , proposal is display like this @username (FirstName LastName)

asaadmahmood commented 8 months ago

@grundleborg That's fine, but an @ shouldn't be needed to show the autocomplete (as you've mentioned)