search

mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost
Other
5 stars 2 forks source link

Use real database for unit tests #42

Closed wiggin77 closed 2 months ago

wiggin77 commented 2 months ago

Summary

Use real database for unit tests. Uses the main server's docker setup as a quick and dirty method to get that support for the plugin. One down-side of this method is you must completely close any MM server containers and network before running these unit tests locally. This will be addressed in the future.

Also fixes some linter errors

❯ golangci-lint run ./...
server/jobs/job_manager.go:56:21: unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive)
    jm.jobs.Range(func(k, v any) bool {
                       ^
server/jobs/job_manager.go:69:21: unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive)
    jm.jobs.Range(func(k, v any) bool {
                       ^
server/store/sqlstore/legal_hold.go:24:2: var-naming: don't use underscores in Go names; var dm_display_name should be dmDisplayName (revive)
    dm_display_name := `

Ticket Link

NONE