fix: end date not required when updating legal hold

mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost

Other

5 stars 2 forks source link

fix: end date not required when updating legal hold #58

Closed fmartingr closed 1 month ago

fmartingr commented 1 month ago

Summary

Make the end date field not required to avoid validation errors when the form can be successfully submitted.

Closes #56

mickmister commented 1 month ago

@fmartingr Does submitting an empty end date have any side effects?

fmartingr commented 1 month ago

@fmartingr Does submitting an empty end date have any side effects?

AFAIK a legal hold with no end date is allowed by the backend, it means that the legal hold will be in place until manually released.

mickmister commented 1 month ago

I'm not experiencing this issue on the master branch for some reason. This is working for me in the desktop app and in Arc browser. @fmartingr Were you able to reproduce the issue for creating this PR?

fmartingr commented 1 month ago

I'm not experiencing this issue on the master branch for some reason. This is working for me in the desktop app and in Arc browser. @fmartingr Were you able to reproduce the issue for creating this PR?

When I tested it the field was red, I don't remember now if the legal hold didn't had an end date or if I removed it myself, thus focusing the field and triggering the validation.

EDIT: Confirming that validation happens on focus/blur.

fmartingr commented 1 month ago

@AayushChaudhary0001 can you add this to the QA pipeline please?