mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost
Other
5 stars 2 forks source link

Store S3 bucket secret in KV store #63

Closed mickmister closed 2 weeks ago

mickmister commented 1 month ago

Summary

This PR makes it so when the admin submits the custom S3 bucket settings, we store it in the KV store, and store a string of asterisks in the server config. This is so we never expose the saved secret to the client later.

This PR also requires upgrading the MM server dependency. ATM this PR sets it to a very recent version, though it only needs to be up to 8.0 for the ConfigurationWillBeSaved hook.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-legal-hold/issues/54