search

mattermost / mattermost-plugin-legal-hold

Plugin to create and manage legal holds in Mattermost
Other
5 stars 5 forks source link

Legal hold plugin's functionality not working on cloud servers of MM #69

Closed AayushChaudhary0001 closed 3 months ago

AayushChaudhary0001 commented 3 months ago

While testing the master branch I got to know that the plugin's functionality is not working well on cloud servers. The ZIP file downloaded through the system console does not contains the data the user demands for. I am attaching a supporting video which explains complete scenario.

https://github.com/mattermost/mattermost-plugin-legal-hold/assets/116162036/63916e64-3d42-4cff-ba38-41115f47e274

wiggin77 commented 3 months ago

@AayushChaudhary0001 are you using the API to trigger the job to run manually for your test as per this PR? https://github.com/mattermost/mattermost-plugin-legal-hold/pull/43

Otherwise, when you set the time of day in the Hold, it will not run the job until that time the next day.

mickmister commented 3 months ago

@wiggin77 I'm thinking the same here. It seems the job just has not run yet in the case of the gif above. I've creates a PR to help surface the feature of running the job on demand https://github.com/mattermost/mattermost-plugin-legal-hold/pull/71

@AayushChaudhary0001 Can you please try this out and see if you experience the same issue?

wiggin77 commented 3 months ago

@mickmister We may need a button to trigger the job manually. The API accessed via curl is too hard to discover.

AayushChaudhary0001 commented 3 months ago

@mickmister I tried this way of running the job, and I was able to run it as many times as I wanted. But still I am facing the same issue, the file downloaded does not contain the data I am trying to fetch from the created legal hold configurations.

We tried a way to run the job multiple times in a day(every minute actually) by performing some code changes our side, but still the result was the same.

wiggin77 commented 3 months ago

@mickmister does this fix https://github.com/mattermost/mattermost-plugin-legal-hold/issues/68 as well?

mickmister commented 3 months ago

@wiggin77 No this issue is essentially "the zip file is blank because the enumeration of files doesn't work". So all files are missing from the zip file in this case, whereas there are "broken links" to files in the linked issue