search

mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365
Apache License 2.0
14 stars 22 forks source link

Re-implement autorespond feature #227

Open mickmister opened 3 years ago

mickmister commented 3 years ago

The autorespond feature was reverted due to it increasing the size of the settings panel interactive post past the limit that post.Props allows. The task here is to adjust the settings panel to accommodate for this restriction, and allow the autorespond feature to have its settings in the settings panel post.

PR that reverts the feature: https://github.com/mattermost/mattermost-plugin-mscalendar/pull/226

Also something that has come up in discussion is that the autorespond needs to make sure it's not going to respond to itself. This may happen when two users are both in a meeting and one sends the other a DM.

If we see that a user in a meeting is DM'd, and the DM is made by the bot, we should ignore the DM and not respond.

hanzei commented 3 years ago

In v6.0 post props size won't be an issue any longer due to https://github.com/mattermost/mattermost-server/pull/18370. Can we get the feature back into the code base if we bump the minimum server version?

mickmister commented 3 years ago

@DHaussermann Please see @hanzei's comment above. He is suggesting we add the autorespond feature back in because the settings panel issue would be fixed with MM server v6. What are your thoughts on this?

@hanzei The feature is actually untested in general, so 1/5 I think we should carry on with this release and we can include the feature in the next release. This way we won't be forcing admins to upgrade to a new MM server version just for this one requirement.

maisnamrajusingh commented 3 years ago

@hanzei looks like I don't have access to this repo yet but I am already working on this.

@michelengelen I am not too familiar with gomock. could you guide me a bit on how I can generate the mock api for this feature.

michelengelen commented 3 years ago

@maisnamrajusingh I am not the right person to ask for help, since I have almost 0 experience in using go ... @jespino or @hmhealey would you be able to help here?

hanzei commented 3 years ago

@maisnamrajusingh mocks are generated using make mocks which are defined in https://github.com/mattermost/mattermost-plugin-mscalendar/blob/94117084bd2260d1b598db5626f82549551d96a2/build/custom.mk#L18-L32

Is there anything else you need to get started?