search

mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365
Apache License 2.0
13 stars 20 forks source link

Common code refactor, back to mscalendar plugin #334

Closed fmartingr closed 9 months ago

fmartingr commented 9 months ago

Summary

codecov-commenter commented 9 months ago

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (c1bd4d3) 19.68% compared to head (e119958) 20.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## migrate-to-gcal #334 +/- ## =================================================== + Coverage 19.68% 20.96% +1.28% =================================================== Files 81 67 -14 Lines 4019 3448 -571 =================================================== - Hits 791 723 -68 + Misses 3133 2632 -501 + Partials 95 93 -2 ``` | [Files](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [calendar/command/connect.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvY29tbWFuZC9jb25uZWN0Lmdv) | `75.00% <100.00%> (ø)` | | | [calendar/command/disconnect.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvY29tbWFuZC9kaXNjb25uZWN0Lmdv) | `100.00% <100.00%> (ø)` | | | [calendar/command/event.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvY29tbWFuZC9ldmVudC5nbw==) | `0.00% <ø> (ø)` | | | [calendar/engine/availability.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2F2YWlsYWJpbGl0eS5nbw==) | `54.97% <ø> (ø)` | | | [calendar/engine/calendar.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2NhbGVuZGFyLmdv) | `15.85% <ø> (ø)` | | | [calendar/engine/client.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2NsaWVudC5nbw==) | `62.50% <ø> (ø)` | | | [calendar/engine/daily\_summary.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2RhaWx5X3N1bW1hcnkuZ28=) | `44.87% <ø> (ø)` | | | [calendar/engine/event\_responder.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2V2ZW50X3Jlc3BvbmRlci5nbw==) | `0.00% <ø> (ø)` | | | [calendar/engine/filters.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL2ZpbHRlcnMuZ28=) | `74.00% <ø> (ø)` | | | [calendar/engine/mscalendar.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-Y2FsZW5kYXIvZW5naW5lL21zY2FsZW5kYXIuZ28=) | `100.00% <100.00%> (ø)` | | | ... and [57 more](https://app.codecov.io/gh/mattermost/mattermost-plugin-mscalendar/pull/334?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fmartingr commented 9 months ago

It seems that since I moved all common code it shows up as "new" so the lint is failing for all known issues that were already there. Will fix those in a bit.

fmartingr commented 9 months ago

Adding @lieut-data and @hanzei as additional reviewers to share the load. Not an in-depth review is needed, just making sure I didn't leave anything obvious.