mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365
Apache License 2.0
13 stars 20 forks source link

#25168 Microsoft Calendar O365 README > Split out admin content to child pages #344

Closed Reene-Simon closed 7 months ago

Reene-Simon commented 8 months ago

Summary

This PR organizes the README section as per the instructions in the issue description. I have used the reviews given for a similar issue, namely the Bitbucket README and have tried to incorporate the instructions given by the reviewers. Hence, I haven't relinked the images as per given in the ticket. If this step is necessary, do let me know and I'll make the required changes. These are the main changes that have been done:

  1. Created a table of contents as mentioned
  2. Made a new admin-guide file under the docs folder
  3. Moved all configuration details into the admin-guide file
  4. Linked all the links and the table of contents according to the changes made

Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/25168

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65b2e67) 23.71% compared to head (897d1a6) 23.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #344 +/- ## ======================================= Coverage 23.71% 23.71% ======================================= Files 62 62 Lines 3087 3087 ======================================= Hits 732 732 Misses 2274 2274 Partials 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Reene-Simon commented 8 months ago

@cwarnermm @mickmister all the changes have been made. Please do review it.

mickmister commented 8 months ago

@hanzei There is a similar lint issue here too like https://github.com/mattermost/mattermost-plugin-bitbucket/pull/127#discussion_r1384577956

mickmister commented 8 months ago

@Reene-Simon We are in the process of resolving a linting issue in our CI pipeline. We can merge once this is fixed

Reene-Simon commented 8 months ago

@mickmister yeah sure no worries!

mickmister commented 7 months ago

Thanks @Reene-Simon!