mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365
Apache License 2.0
13 stars 20 forks source link

Disable unused-parameter golangci check #346

Closed mickmister closed 7 months ago

mickmister commented 7 months ago

Summary

Same as https://github.com/mattermost/mattermost-plugin-nagios/pull/49

Ticket Link

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65b2e67) 23.71% compared to head (16d8c6e) 23.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ======================================= Coverage 23.71% 23.71% ======================================= Files 62 62 Lines 3087 3087 ======================================= Hits 732 732 Misses 2274 2274 Partials 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 7 months ago

/update-branch

mickmister commented 7 months ago

@toninis Any idea why the merge/blocked check is stuck at "Waiting for status to be reported"? I've seen this happen before but don't recall what needs to be done to resolve it

toninis commented 7 months ago

@toninis Any idea why the merge/blocked check is stuck at "Waiting for status to be reported"? I've seen this happen before but don't recall what needs to be done to resolve it

Should be ok . These are some remnants from the webhook URL migration that we forgot to switch 😄

mickmister commented 7 months ago

@toninis What needed to be done to unblock this PR? Wondering about other PRs like https://github.com/mattermost/mattermost-plugin-mscalendar/pull/267

toninis commented 7 months ago

@toninis What needed to be done to unblock this PR? Wondering about other PRs like #267

An empty commit will do the trick 👍🏼