mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365

Apache License 2.0

13 stars 21 forks source link

[MM-188] Add feature to update custom status and status of the user during meeting #355

Closed ayusht2810 closed 7 months ago

ayusht2810 commented 8 months ago

Summary

Added feature to update custom status of the user during meeting
Added feature to set status of the user from the options provided in the dropdown during the meeting

Ticket Link

228

Screenshots

What to test?

Custom status gets updated during a meeting.
User status gets updated to the selected value during a meeting.
No change in user status during overlapping meetings or when there are no attendees.
No change of user custom status during overlapping meetings, when there are no attendees, or when there is already a custom status set.

How to test?

Create a meeting in the MS Calendar.
Run slash command /mscalendar settings, select an option from the Update Status setting, and check the updated status on the Mattermost.
Run slash command /mscalendar settings, set the Set Custom Status setting to yes, and check the updated custom status on the Mattermost.

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 42.85714% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 24.72%. Comparing base (b1bcb7b) to head (0ceffcd).

Files	Patch %	Lines
server/mscalendar/availability.go	53.68%	33 Missing and 11 partials :warning:
server/mscalendar/welcome_flow.go	0.00%	13 Missing :warning:
server/mscalendar/settings.go	0.00%	9 Missing :warning:
server/mscalendar/welcomer.go	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #355 +/- ## ========================================== + Coverage 23.71% 24.72% +1.01% ========================================== Files 62 62 Lines 3087 3163 +76 ========================================== + Hits 732 782 +50 - Misses 2274 2292 +18 - Partials 81 89 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 7 months ago

@cwarnermm Can you please take a look at the user-facing strings in this PR? Thanks 🙂

These are primarily in server/mscalendar/welcome_flow.go

raghavaggarwal2308 commented 7 months ago

@mickmister @cwarnermm @hanzei @fmartingr Because of a lot of conflicts on this PR after merging https://github.com/mattermost/mattermost-plugin-mscalendar/pull/267 PR. We are creating a separate PR by creating a new branch from the master and cherry-picking the commits of this PR there so that the changes on the master branch are not affected by mistake.

All the review fixes mentioned in this PR are fixed there

New PR link: https://github.com/mattermost/mattermost-plugin-mscalendar/pull/359