search

mattermost / mattermost-plugin-mscalendar

Mattermost plugin for Microsoft Office365
Apache License 2.0
13 stars 21 forks source link

version 1.3.0 says it's version 1.2.1 #366

Open KuestenKeks opened 4 months ago

KuestenKeks commented 4 months ago

Very minor issue :P I've just installed version 1.3.0 and tried /mscalendar info. It prints:

Mattermost Microsoft Calendar plugin version: 1.2.1, 81a10d7, built Wed May  8 16:12:00 UTC 2024
mickmister commented 4 months ago

Thanks for this issue @KuestenKeks :+1:

@hanzei Any ideas on how this may have happened? The tag is v1.3.0, and the release artifact there has 1.3.0 in the plugin.json file

hanzei commented 3 months ago

https://github.com/mattermost/mattermost-plugin-mscalendar/blob/f26a8299bdc4fb4f98201ce3fef6afbc1c667de9/server/manifest.go#L8-L11 is not up to date. That happens because the plugin is in a weird state. make apply got removed, but embedding plugin.json (like we go for other plugins) is not implemented.