search

mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

Access control #219

Open darias416 opened 1 year ago

darias416 commented 1 year ago

In preparation for deploying the plugin in production, Hercules needs a way to control access to the plugin to facilitate a staged rollout.

Currently, the only existing mechanism is the "Enabled Teams" configuration. However, Hercules has only 1 Mattermost Team with several thousand users.

mkdbns commented 1 year ago

Did SN mention a preferred way that they would like to be able to control onboarding of users?

darias416 commented 1 year ago

@mkdbns the preferred method would be to select people based on the group they belong to. However, I confirmed they don't have AD/LDAP Groups enabled. The only other ways I can think of identifying different types of users is by using the MM System Roles or MM User Roles

cc: @johndavidlugtu @jasonblais @maxwellpower @jespino

jasonblais commented 1 year ago

@darias416 this may be a good topic to raise with Spiros on our morning call, given they manage the Cloud deployment & may have additional suggestions around access control.

johndavidlugtu commented 1 year ago

Was there additional suggestions from Spiros and team around access control?

jasonblais commented 1 year ago

@johndavidlugtu no concrete solutions yet, but we'll be meeting again next Tuesday to discuss options further

darias416 commented 1 year ago

Was there additional suggestions from Spiros and team around access control?

@johndavidlugtu we discussed the possibility of leveraging Okta groups. We will need to explore further.

manojmalik20 commented 1 year ago

@darias416 I think this issue can be closed now as this is done via the whitelist feature. Here's the PR - https://github.com/mattermost/mattermost-plugin-msteams-sync/pull/342