search

mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

Improve Users sync #545

Closed enahum closed 7 months ago

enahum commented 7 months ago

Summary

Refactor syncUsers so it reads better and fixes the issue where users being activated and deactivated constantly.

We now do not create synthetic users if they are not present in MM but disabled on MS Teams

Ticket Link

https://mattermost.atlassian.net/browse/MM-56942 https://mattermost.atlassian.net/browse/MM-56886

lieut-data commented 7 months ago

@JulienTant, adding you as reviewer as part of helping to own all things synthetic users. Happy to chime in as needed -- feel free to ping me!

JulienTant commented 7 months ago

I was reviewing the PR and accidentally committed and pushed fixes for something else here 😓 reverted now, sorry for the noise!

jespino commented 7 months ago

@enahum there is a conflict, but other than that looks good to me.

enahum commented 7 months ago

@jespino can you help look into why the tests are failing?

JulienTant commented 7 months ago

@enahum I reran the job and everything went green! :)