mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

MM-57376, MM-57374, MM-57368: Connection Invites—whitelist and refinements #599

Closed calebroseland closed 6 months ago

calebroseland commented 6 months ago

Summary

For ease of use, the main option is now a dropdown, the max. invite pool size now defaults to 10, and help text is rearranged for clarity.

CleanShot 2024-04-15 at 17 03 34

CleanShot 2024-04-15 at 17 03 40

"Whitelist" now means "is eligible to receive a connection invite". Related store methods have been refactored/repurposed and now serve the new whitelist semantics.

The old "whitelist" really meant "user has connected at some point in time and should always be permitted to reconnect if they become disconnected." — this "has-connected" tracking has moved to new columns in msteamssync_users - .lastconnectat and .lastdisconnectat.

The old msteamssync_whitelisted_users table is not removed, but its rows are deleted as a marker that the migration was completed. This is largely backwards compatible as prefillWhitelist in prior versions rebuilds the old whitelist from the users table (only presently-connected users, however.) Tracking of users who were previously-connected, but are not presently-connected is not accessible in rollback scenarios, but is preserved in the new .lastconnectat and .lastdisconnectat columns for all forward versions, even in the event of rollback and re-upgrade.

Ticket Link