We are calling GetUser for each synthetic during the syncUsers job, but we only need to make this call if autopromote is on.
Reminder: the reason why we need this call is because GetUsers does not return AuthData: it's sanitized, so we make GetUser to get this info. Ideally, plugins should have access to more unsanitized data, but it involves a much heavier change on mattermost server, getting security validation etc... the change is probably not worth investing time in right now.
I don't expect this PR to have a significant positive perf impact as Jesus believes that GetUser is pulling data from cache rather than DB, but it's probably still better to only do the call when needed rather than all the time.
QA
I think for QA, just making sure that the syncUsers job will works as before is the best way to go
Summary
We are calling GetUser for each synthetic during the syncUsers job, but we only need to make this call if autopromote is
on.Reminder: the reason why we need this call is because
GetUsersdoes not returnAuthData: it's sanitized, so we makeGetUserto get this info. Ideally, plugins should have access to more unsanitized data, but it involves a much heavier change on mattermost server, getting security validation etc... the change is probably not worth investing time in right now.I don't expect this PR to have a significant positive perf impact as Jesus believes that
GetUseris pulling data from cache rather than DB, but it's probably still better to only do the call when needed rather than all the time.QA
I think for QA, just making sure that the syncUsers job will works as before is the best way to go
Ticket Link
https://mattermost.atlassian.net/browse/MM-57821