search

mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

MM-57535 Don't automute guests nor bots #629

Closed sbishel closed 5 months ago

sbishel commented 5 months ago

Summary

Don't automute Direct messages with Guests, nor Bots

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-57288 Fixes https://mattermost.atlassian.net/browse/MM-57535

Unit test won't pass until we are using v9.8 of the server, as it contains a fix for creating channels with remote users.

sbishel commented 5 months ago

@lieut-data - I don't think this PR is even necessary anymore. https://mattermost.atlassian.net/browse/MM-58053 only mutes if Synthetic user, and Guest nor Bot would ever be synthetic. I think we can close.

lieut-data commented 5 months ago

It's true that https://mattermost.atlassian.net/browse/MM-58053 supercedes this, but I'd love to keep the unit tests at least as they are valid cases that we'd want to guarantee going forward regardless.