mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

[MM-57533] Send a warning when selective sync blocks a message #630

Closed JulienTant closed 2 months ago

JulienTant commented 2 months ago

Summary

Send a warning when selective sync blocks a message + Add tests on the MessageWIllBePosted hook.

QA Steps

Ticket Link

https://mattermost.atlassian.net/browse/MM-57533

JulienTant commented 2 months ago

I want to make sure I understand your feedback correctly @lieut-data; do I leave my ephemeral message in place now until we pivot to unmuting Teams Primary<-->Teams Primary or do you think it's better not to implement it at all, and I clean this out of this PR but leave my other changes?

lieut-data commented 2 months ago

I want to make sure I understand your feedback correctly @lieut-data; do I leave my ephemeral message in place now until we pivot to unmuting Teams Primary<-->Teams Primary or do you think it's better not to implement it at all, and I clean this out of this PR but leave my other changes?

I think we ended up chatting 1:1 in Mattermost, but to close the loop: let's keep this for interactions between an MS Teams primary user with only synthetic users, as those won't sync, but otherwise remove.

lieut-data commented 2 months ago

@JulienTant, propose we keep just the unit test coverage from this change but otherwise revert any net new messages as we work towards defining next steps for the project.

JulienTant commented 2 months ago

WIll close this as the feature is not relevant and tests have been added since