search

mattermost / mattermost-plugin-msteams

MS Teams plugin for Mattermost
Other
13 stars 11 forks source link

MM-58052 - Only sync if a user in the chat is remote #637

Closed sbishel closed 2 months ago

sbishel commented 2 months ago

Summary

Updates `chatMembersSpanPlatforms" to only return true if a synthetic user (user.IsRemote()) is included.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-58052

sbishel commented 2 months ago

@lieut-data - Could you take a quick look at the changes for calling apiclient instead of API? More changes than I expected and I want to make sure I did it correctly, I wasn't aware of apiclient.

This was more of an exercise for me, as the PR I'm currently working on handling disconnected users changes most of this code. ie. ChannelMembersSpanPlatforms gets replaced, that name no longer makes sense as that's not what we check anymore.

I do want to get this one merged, so I can get the other PR merged and ready. Thanks

lindy65 commented 2 months ago

Thanks for QA-deferring @sbishel - we can test this at a bug bash :)