search

mattermost / mattermost-plugin-msteams

Other
12 stars 10 forks source link

Rewrite message hooks tests part2 #658

Closed lieut-data closed 1 month ago

lieut-data commented 1 month ago

Summary

This picks up where we left off on expunging mock testing, this time for (the chat portion) of MessageWillBePosted. In addition to bumping the server dependencies, introduce a new runPermutations generic that takes a struct of booleans and simplifies testing all the combinations. (Thanks @JulienTant for pushing me towards generics to make this cleaner!)

Ticket Link

Relates-to: https://mattermost.atlassian.net/browse/MM-55512

sbishel commented 1 month ago

I think your conflict is just a variable name change I introduced. So, I think you can just remove the conflict code. https://github.com/mattermost/mattermost-plugin-msteams/pull/652/files#diff-d581d8e52a46c862bbe83a49a791197b964a9df2c95fc94185925c6e44323116L535