mattermost / mattermost-plugin-msteams

Other
12 stars 10 forks source link

[MM-58308] Add number of attachments #666

Closed JulienTant closed 1 month ago

JulienTant commented 1 month ago

Summary

Add a footer to the notification letting the user know if file attachments were sent:

image

Ticket Link

https://mattermost.atlassian.net/browse/MM-58308

lieut-data commented 1 month ago

This looks great, @JulienTant! Could I trouble you to rebase on the (literally just pushed) https://github.com/mattermost/mattermost-plugin-msteams/pull/667 and add unit test coverage for these cases using the new framework? Apologies for moving the code slightly, but happy to help resolve any conflicts :p

lieut-data commented 1 month ago

(Updated link above to https://github.com/mattermost/mattermost-plugin-msteams/pull/667)

JulienTant commented 1 month ago

I was just adding tests :P Will rebase.

JulienTant commented 1 month ago

Rebased, still need to add tests

JulienTant commented 1 month ago

@lieut-data added tests using the permutator :P Please do not refactor your test on your branch 🤣

JulienTant commented 1 month ago

@lieut-data updated this to exclude codeblocks and reply blocks from attachment count.