In the past, we relied on transactions at the application layer, and had embedded FOR UPDATE additions to various queries in support of same. This stopped working once we added support for read replicas and marked these APIs with db:withReplica. But notably, this was only an issue when a read replica is actually setup and the database enforces read-only semantics.
Since we stopped using transactions this way, these FOR UPDATE additions are redundant and can simply be removed.
Summary
In the past, we relied on transactions at the application layer, and had embedded
FOR UPDATEadditions to various queries in support of same. This stopped working once we added support for read replicas and marked these APIs withdb:withReplica. But notably, this was only an issue when a read replica is actually setup and the database enforces read-only semantics.Since we stopped using transactions this way, these
FOR UPDATEadditions are redundant and can simply be removed.Ticket Link
None.