search

mattermost / mattermost-plugin-nps

Collect and Send NPS surveys
Apache License 2.0
8 stars 10 forks source link

Fix for: EnablePermalinkPreviews kills nps plugin #85

Open catalintomai opened 2 years ago

catalintomai commented 2 years ago

The NPS plugin fails to function when EnablePermalinkPreviews is on. More details: https://github.com/mattermost/mattermost-plugin-playbooks/pull/797 and https://community-release.mattermost.com/private-core/channels/pluginspermalink-previews-issue

This is opened to address the issue similarly to the Playbooks plugin (basically porting the above)

hanzei commented 2 years ago

Closing per https://community-daily.mattermost.com/private-core/pl/q5snnfqccpndtnpdkf3ce4es3a

catalintomai commented 2 years ago

@hanzei - to my understanding - https://github.com/mattermost/mattermost-server/pull/18613 is a temporary fix - and if the PostPreview is added back the issue will occur again(?) - shouldn't we actually port cpoile's original fix (https://github.com/mattermost/mattermost-plugin-playbooks/pull/797) ?

hanzei commented 2 years ago

@catalintomai Adding PostPreview back would break all plugin that are not complied against at least 6.0. This would break some Community plugins. Would we do that?

catalintomai commented 2 years ago

@hanzei - at a certain point we'll have to add PostPreview back (and/or other potentially future breaking additions) - that is my hypothesis. Or do you see the current state as permanent? If not, then we'll have to fix these plugins anyway (doing it for nps and apps might provide an example/path to follow for the community ones - playbooks is fixed by cpoile fwik).