search

mattermost / mattermost-plugin-servicenow

ServiceNow plugin for Mattermost
Apache License 2.0
5 stars 5 forks source link

Several Modals seem to randomly be in the open state after the webapp has been left idle #120

Open DHaussermann opened 1 year ago

DHaussermann commented 1 year ago

I'm seeing an odd behavior with Service Now. After I have left my local Mattermost instance idle for some time (maybe 2 hours or so), when I return to the browser tab, I see several modals open and their overlays showing for no apparent reason.

https://user-images.githubusercontent.com/35588783/202306173-71dbc92f-12d7-4745-a749-7e3e8811af3c.mov

I'm working to see if there is any action that is causing this.

image image image image

In the image set above you can see that 4 modals where open. I have placed them chronologically

ayusht2810 commented 1 year ago

This issue is fixed in the latest release v2.3.1. Please confirm and close this issue. @DHaussermann

DHaussermann commented 1 year ago

@ayusht2810 Are you certain this is resolved? image

This seems like something we should fix before release if possible.

Note @mkdbns you can reach out to me if we need more concrete repro steps. This does not seem to happen with several modal as it did before but I can repro it for 1 modal in the other client.

manojmalik20 commented 1 year ago

@hanzei @DHaussermann We asked a question regarding this issue on the community - https://community.mattermost.com/core/pl/18ibezsxbindirhzb1xomdau4y. As per the suggestion there, we are planning to implement a custom post for all the notifications and the "Shared by" post. We are planning to make it look like Mattermost slack attachment so that it looks the same but the handling of buttons will be different. That will fix this issue. Also, we will add the logic that those posts will use slack attachments to render in the mobile app so that mobile app users can also see all the posts but in the mobile app, the post will not contain any buttons as the mobile app doesn't support opening custom modals.

Should we go ahead with this or do you have some concerns/suggestions regarding this?

hanzei commented 1 year ago

Does that mean this bug only happens when a user is connected with more the one client?

manojmalik20 commented 1 year ago

Yes.

ayusht2810 commented 1 year ago

@DHaussermann @hanzei should we proceed with this approach?

hanzei commented 1 year ago

Sound good to me. But I would consider it an edge case. Other plugins suffer the same issue, e.g. GitHub.

@asatkinson What do you think?

asatkinson commented 1 year ago

I think we decided that this was worth fixing, but not worth holding release up over. For Phase 3 this will be fixed.