search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
133 stars 121 forks source link

Fix build issues #104

Closed lieut-data closed 4 years ago

lieut-data commented 4 years ago

Summary

Fix linting issues introduced by my recent updates. Sync with improvements from the demo plugin as well. (A separate PR is pending to update the demo plugin with changes from the starter-template.)

lieut-data commented 4 years ago

Oops, my apologies @mickmister -- I forgot to push those. I bet we could check for this in the build process to ensure npm install doesn't bring in anything newer. I've verified that /now/ the package-lock.json doesn't change, even after a make clean.

lieut-data commented 4 years ago

Thanks, @hanzei! Updated to address both your comments.