search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
129 stars 120 forks source link

Add separate go.mod to build folder #119

Closed mickmister closed 4 years ago

mickmister commented 4 years ago

Summary

Dependencies have been added to the plugin root directory's go.mod in order to support new functionality in the build process. As a result, plugins that sync with the starter template have had their root go.mod file altered to support the build functionality.

Having a separate go.mod file in the build folder allows us to more easily sync the deps needed to build across repos, as well as keep the build deps separate from the main deps of the plugin.

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-starter-template/issues/113

mickmister commented 4 years ago

I see the repo sync tool PR already has its dependencies in a separate go.mod file now 0b067fe (#86) in the build/sync folder. I've excluded the dependencies that are specific to the sync tool in this PR. @hanzei Do you think all build dependencies should go in one go.mod file in the build directory?

hanzei commented 4 years ago

Yes, that makes sense to me. A separate go.mod for every directory in build seams to much, when we can just keep one.

hanzei commented 4 years ago

The CI failure will be fixed with https://github.com/mattermost/mattermost-plugin-starter-template/pull/124

hanzei commented 4 years ago

/update-branch