search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
129 stars 120 forks source link

Removed file git history #128

Closed tasdomas closed 3 years ago

tasdomas commented 3 years ago

Summary

This pull request modifes the file_unaltered check in the sync tool, used to synchronize plugin repositories with the starter template, to handle the case where the target file does not exist.

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich

jasonblais commented 3 years ago

Great, thanks! @jfrerich ready for your review

hanzei commented 3 years ago

Given that this is a tooling change and I have test it already locally, I'm going to skip QA review for this PR.

hanzei commented 3 years ago

Thanks @tasdomas for all the work you put into this tool :tada:

hanzei commented 3 years ago

The changes seem to have broken CI. @tasdomas Would you mind taking a look at https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-starter-template/428/workflows/508a6d30-001a-4087-b353-52dddc71683c/jobs/981?

tasdomas commented 3 years ago

@hanzei - the CI was broken by github squashing the PR's commits.

https://github.com/mattermost/mattermost-plugin-starter-template/pull/135 is a simple fix (just skipping one test)