search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
129 stars 120 forks source link

Plugin should require confirmation when building with plugin id "com.mattermost.plugin-starter-template" #152

Open mickmister opened 3 years ago

mickmister commented 3 years ago

When I use the starter template for a new project and deploy the plugin to my environment, it always deploys as Plugin Starter Template with id com.mattermost.plugin-starter-template. This is because I'm not thinking about changing the plugin id when I'm creating a POC.

I propose we make it so running the make deploy command (and others like it that build the plugin) would first ask the user something like:

Are you sure you want to build the plugin with an id of "com.mattermost.plugin-starter-template"? Consider editing plugin.json to configure your project.

mickmister commented 3 years ago

@hanzei What are your thoughts on this?

hanzei commented 3 years ago

@mickmister I don't have objection to this change, but I would suggest to only log a message and don't block the flow of a user.

haardikdharma10 commented 3 years ago

Hey @mickmister! This could be a nice addition. @hanzei has a valid point too. Can we change the Makefile wherein we can use $(info message) or $(warning message) in the deploy command, both of which won't stop the execution. If yes, which one do you think will be better to use?

mickmister commented 3 years ago

@haardikdharma10 I agree, and I think using warning makes sense because this message is meant to alert the user to change something.