search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
128 stars 120 forks source link

Add ".nvmrc" file for webapp. #168

Closed avas27JTG closed 1 year ago

avas27JTG commented 2 years ago

It becomes difficult sometimes to use the proper node version for installing the web app dependencies on the hit and trial method as the .nvmrc file is missing. Please let me know if I should create one PR for it, for me the node version that worked correctly was 14.18.0.

hanzei commented 1 year ago

@avas27JTG That would be great!

ecator commented 1 year ago

I was the v14.21.2, but npm didn't work, I used yarn. And there are many other problems such as make check-style and make test doesn't work. Fortunately the make dist and make deploy is ok 😺

I think using the Docker Dev Environments will be better. The go and node version can be fixed in container.

hanzei commented 1 year ago

Fixed with https://github.com/mattermost/mattermost-plugin-starter-template/pull/173

hanzei commented 1 year ago

@ecator Since https://github.com/mattermost/mattermost-plugin-starter-template/pull/163 got merge, node 16.12 is used. Plase open a new issue if you are having issues with that version.